Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hardware][Intel GPU] add XPU bf16 support #12392

Merged
merged 3 commits into from
Feb 2, 2025
Merged

[Hardware][Intel GPU] add XPU bf16 support #12392

merged 3 commits into from
Feb 2, 2025

Conversation

jikunshang
Copy link
Contributor

@jikunshang jikunshang commented Jan 24, 2025 •
edited by github-actions bot
Loading

No description provided.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Jan 24, 2025
mgoin
mgoin reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed to allow this? There are no dependency updates listed - does this require a newer version of OneAPI?

@jikunshang
Copy link
Contributor Author

@mgoin bf16 should be ready after oneapi 2024.2, we forgot to update this.

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 26, 2025
@mgoin mgoin enabled auto-merge (squash) January 26, 2025 03:29
@DarkLight1337
Copy link
Member

Sorry, can you fix the merge conflicts?

@mergify Mergify
Copy link

mergify bot commented Feb 1, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @jikunshang.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 1, 2025
@jikunshang
add xpu bf16 support
12d0583 
Signed-off-by: Kunshang Ji <[email protected]>
@jikunshang
add doc
769fa21 
Signed-off-by: Kunshang Ji <[email protected]>
@jikunshang
minor
21d7040 
Signed-off-by: Kunshang Ji <[email protected]>
auto-merge was automatically disabled February 1, 2025 06:21

Head branch was pushed to by a user without write access

@jikunshang
Copy link
Contributor Author

Sorry, can you fix the merge conflicts?

sure, resolved.

@mergify mergify bot removed the needs-rebase label Feb 1, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 2, 2025 08:42
@DarkLight1337 DarkLight1337 merged commit f256ebe into vllm-project:main Feb 2, 2025
57 of 58 checks passed
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Feb 2, 2025
@jikunshang @Isotr0py
[Hardware][Intel GPU] add XPU bf16 support (vllm-project#12392)
b49a143 
Signed-off-by: Kunshang Ji <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
youngkent pushed a commit to youngkent/vllm that referenced this pull request Feb 3, 2025
@jikunshang @youngkent
[Hardware][Intel GPU] add XPU bf16 support (vllm-project#12392)
8389ca7 
Signed-off-by: Kunshang Ji <[email protected]>
srikanthsrnvs pushed a commit to srikanthsrnvs/vllm that referenced this pull request Feb 3, 2025
@jikunshang @srikanthsrnvs
[Hardware][Intel GPU] add XPU bf16 support (vllm-project#12392)
87e5e8b 
Signed-off-by: Kunshang Ji <[email protected]>
Signed-off-by: Srikanth Srinivas <[email protected]>
sahelib25 pushed a commit to krai/vllm that referenced this pull request Feb 3, 2025
@jikunshang @sahelib25
[Hardware][Intel GPU] add XPU bf16 support (vllm-project#12392)
96aacfc 
Signed-off-by: Kunshang Ji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jikunshang @DarkLight1337 @mgoin